Use update in tests instead of save #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should absolutely keep tests for |
| c.description = "another_mn" | ||
| c.save | ||
| Stripe::Customer.construct_from(customer_fixture) | ||
| Stripe::Customer.update("cus_123", { description: "another_mn" }) | ||
| end | ||
|
|
||
| should "updating should merge in returned properties" do |
There was a problem hiding this comment.
I'm not sure "merge in returned properties" describes what Update does. Maybe we should just delete these tests or keep them the way they are because even though it is deprecated it is good to have test coverage for .save until we entirely remove it
|
Based on the conversation above, I'll close this PR and wait until we fully remove save to remove these tests. Thanks for taking a look! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that save is deprecated in v8.0.0, we want to update the tests to call the static
updatemethod instead ofsave.This PR preserves the functionality of most tests, except for those involving arrays because the previous array tests used
legal_entityonAccounts, which no longer exists in the API, but is a protected field in account.rb soupdatedoes not work on that field. Instead, I update theitemsarray on a Subscription object in those tests.I also removed 2 tests involving
nilid values, since that functionality was unique tosave.